Skip to content

Remove excess logging#17

Merged
dgenr8 merged 1 commit intochain2:masterfrom
dgenr8:remove_excess_logging
Nov 1, 2019
Merged

Remove excess logging#17
dgenr8 merged 1 commit intochain2:masterfrom
dgenr8:remove_excess_logging

Conversation

@dgenr8
Copy link
Copy Markdown
Collaborator

@dgenr8 dgenr8 commented Oct 30, 2019

Suppress logging in CheckProofOfWork when using the reference cpuminer.

@dgenr8
Copy link
Copy Markdown
Collaborator Author

dgenr8 commented Oct 30, 2019

@cryptozeny

@cryptozeny
Copy link
Copy Markdown
Contributor

cryptozeny commented Oct 30, 2019 •
edited
Loading

i think its not related with this PR, but anyway i report.

i ran your build f344f29, but it seems freezing at startup. testnet. i cannot reproduce, but it randomly appears. i can exit only with killall -9

cmd was ./src/qt/bitcoin-qt -usecashaddr=0 -testnet -printtoconsole

image

after build, first freezing. but from second time, its OK

i can kill freezing chain2 with kill -9 PID

@cryptozeny
Copy link
Copy Markdown
Contributor

cryptozeny commented Oct 30, 2019 

generate 1
ProcessNewBlock, block not accepted (code -32603)

debug.log

2019-10-30 23:37:09 keypool reserve 6
2019-10-30 23:37:09 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-10-30 23:37:09 ERROR: CheckProofOfWork(): hash doesn't match subtarget
2019-10-30 23:37:09 ERROR: CheckProofOfWork(): hash doesn't match subtarget
2019-10-30 23:37:09 ERROR: ContextualCheckBlockHeader(): proof of work failed
2019-10-30 23:37:09 ERROR: ProcessNewBlock: AcceptBlock FAILED
2019-10-30 23:37:09 keypool return 6

@cryptozeny
Copy link
Copy Markdown
Contributor

cryptozeny commented Oct 30, 2019

image

@cryptozeny
Copy link
Copy Markdown
Contributor

cryptozeny commented Oct 30, 2019

image

@cryptozeny
Copy link
Copy Markdown
Contributor

cryptozeny commented Oct 30, 2019

setgenerate true 1 OK as before

@dgenr8 dgenr8 force-pushed the remove_excess_logging branch from f344f29 to 3d2b1e4 Compare October 31, 2019 05:12
@dgenr8
Copy link
Copy Markdown
Collaborator Author

dgenr8 commented Oct 31, 2019 •
edited
Loading

@cryptozeny Thanks, I pushed an update to this PR to fix a misplaced parenthesis. Please try again.

Be aware that 'generate 1' is unlikely to succeed on testnet because it defaults to 1,000,000 hash tries. At minimum testnet (=mainnet) difficulty you need about 7,000,000 * 600 = about 4,200,000,000 tries. You can enter # of tries in the next parameter.

Unless there's been no block for a while. Then it will probably succeed on the first try.

Anyway it should not return an error anymore.

@cryptozeny
Copy link
Copy Markdown
Contributor

cryptozeny commented Nov 1, 2019 •
edited
Loading

3d2b1e4 no error on generate 1

2019-11-01 15:23:04 keypool reserve 9
2019-11-01 15:23:04 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:05 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:06 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:07 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:08 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:09 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:10 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:11 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:12 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:13 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:14 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:15 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:17 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:18 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:19 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:20 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:20 keypool return 9

@cryptozeny
Copy link
Copy Markdown
Contributor

cryptozeny commented Nov 1, 2019

Be aware that 'generate 1' is unlikely to succeed on testnet because it defaults to 1,000,000 hash tries. At minimum testnet (=mainnet) difficulty you need about 7,000,000 * 600 = about 4,200,000,000 tries. You can enter # of tries in the next parameter.

but out of range

image

@dgenr8 dgenr8 force-pushed the remove_excess_logging branch from 3d2b1e4 to 32a2c7d Compare November 1, 2019 15:33
@dgenr8
Copy link
Copy Markdown
Collaborator Author

dgenr8 commented Nov 1, 2019

Rebased to remove duplicate of the 200GB fix.

@dgenr8 dgenr8 merged commit 4f0510d into chain2:master Nov 1, 2019
@dgenr8
Copy link
Copy Markdown
Collaborator Author

dgenr8 commented Nov 1, 2019

Thanks @cryptozeny!

@dgenr8 dgenr8 deleted the remove_excess_logging branch May 10, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cryptozeny cryptozeny cryptozeny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgenr8 @cryptozeny