Add .deep.include for deep equality comparisons#761
Merged
keithamus merged 3 commits intochaijs:masterfrom Aug 16, 2016
Merged
Conversation
Member
|
Okay, this is all good. @lucasfcosta if you want to, we can just review this one and close #744, #757, #758, and #760, or alternatively merge each one in order. |
Member
|
@keithamus I'd prefer reviewing each one separately. It looks better to me since they are different small changes regarding different things, even though they depend on each other. Before continuing my review of each one of those, I added comments to the first two PRs I reviewed regarding the branch these changes are going into, shouldn't they be going to |
- Previously, `.include` was using strict equality for non-negated property inclusion, but deep equality for negated property inclusion and array inclusion. This fix causes `.include` to always use strict equality.
Contributor
Author
|
@keithamus @lucasfcosta Pushed new version! |
Member
|
LGTM! |
Contributor
Author
|
@lucasfcosta Thanks for reviewing :D |
Member
|
LGTM 👍 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
.not.property(name, val)behavior #744, Breaking: Rename.deep.propertyto.nested.property#757, Add.deep.propertyfor deep equality comparisons #758, and Breaking: Fix.includeto always use strict equality #760 are prerequisites for this PR. I recommend reviewing them first, and then only reviewing the newest commit in this PR.