You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @terminalchai — the conflict is small, only 3 spots.
Here is exactly what to keep in each one:
Conflict 1 — keep the main version (with the checkmark):
console.log(" ✓ generateExtensionsJson - creates valid .vscode/extensions.json");
Conflict 2 — keep the main version (with the checkmark):
console.log(" ✓ generateExtensionsJson - auto-creates .vscode directory");
Conflict 3 — keep the main version (the one with two assert.ok checks):
assert.ok(
instructions.includes("Add to PATH"),
"Windows instructions should mention adding VS Code to PATH"
);
assert.ok(
instructions.includes("restart your terminal"),
"Windows instructions should tell the user to restart the terminal"
);
console.log( ✓ getCodeInstallInstructions - returns: "${instructions.slice(0, 50)}...");
In each conflict block, delete everything from <<<<<<< to >>>>>>>
and replace it with the lines above. Your mock tests below are
untouched and perfect as-is.
Click "Resolve conflicts" on the PR page, make those 3 swaps,
click "Mark as resolved" then "Commit merge" and I will merge
right away! 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installExtensions()without calling the realcodeCLIonProgressis called once per extension andresultslength matches input lengthValidation
npm testnpm run lintCloses #25