Update cfb-mode and aes to version 0.8.x#21
Conversation
cfal
left a comment
There was a problem hiding this comment.
thanks for your contribution 🙏 have you tested that vmess still works as expected?
src/udp_direct_message_stream.rs
Outdated
| } | ||
| Poll::Ready(result) => { | ||
| let _ = this.resolving_locations.remove(target).unwrap(); | ||
| this.resolving_locations.remove(target); |
There was a problem hiding this comment.
this was intentional because it's an error that should never occur - could we leave it or replace with an expect?
There was a problem hiding this comment.
the returned value never used, why we need call unwrap() or expect()?
There was a problem hiding this comment.
unwrap shows that a value exists, and panics otherwise. if we don't unwrap or expect, and a bug is introduced in the code where the target key is empty, this would not panic.
There was a problem hiding this comment.
ok new update has pushed
|
yeah, i use shoes for my own instead v2flay for a long time. |
resolved #4