Merged
Conversation
…repare to upgrade them
cfal
reviewed
Aug 28, 2024
Owner
cfal
left a comment
There was a problem hiding this comment.
looks great! thanks for taking the time.
src/tcp/tcp_server.rs
Outdated
| } else { | ||
| debug!("{}:{} finished successfully", addr.ip(), addr.port()); | ||
| } | ||
| // if let Err(e) = |
Owner
There was a problem hiding this comment.
uncomment? guessing you find these errors spammy?
Contributor
Author
There was a problem hiding this comment.
sorry you are right, these codes already uncomment now. seems some error before, then i comment them out. anyway it looks good now
cfal
reviewed
Aug 28, 2024
| #[inline] | ||
| pub fn allocate_vec<T>(len: usize) -> Vec<T> { | ||
| let mut ret = Vec::with_capacity(len); | ||
| let _remaining = ret.spare_capacity_mut(); |
| let padding_len: usize = rng.gen_range(1..=900); | ||
|
|
||
| location_vec.reserve(padding_len + 2); | ||
| let _remaining = location_vec.spare_capacity_mut(); |
Contributor
Author
There was a problem hiding this comment.
it's the recommend by cargo clippy, the details here: https://rust-lang.github.io/rust-clippy/master/index.html#/uninit_vec
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decrease warning according to
cargo clippy. fixed dependencies version, prepare to upgrade them