Merged
Conversation
…ify a machine as having RRAS installed.
BrandesEric
commented
Mar 6, 2026
Contributor
Author
There was a problem hiding this comment.
This file is actually a rename, but it was different enough that the git heuristics flag it as new. A lot of it is NOT new.
BrandesEric
commented
Mar 6, 2026
Contributor
Author
There was a problem hiding this comment.
This file is ALSO a rename, but git thinks it's new (and the old one deleted).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to RRAS, we're now adding support (in theory) for Direct Access as well.
Part of this commit is to update the detection of both RRAS and DA.
We now use the
Get-RemoteAccessoutput primarily, as opposed to a series of checks that we performed previously. Those checks could sometimes prevent a machine from being identified as having one of these services installed.If direct access is the target software for an update, we restart the
RaMgmtSvc- for RRAS it'sRemoteAccess.