Remove instructions for CentOS 6 and RHEL 6#676
Merged
bmw merged 1 commit intocertbot:masterfrom Dec 8, 2020
Merged
Conversation
bmw
approved these changes
Dec 8, 2020
Member
bmw
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I think there's a chance we'll want the instructions back for non-EOL'd distros for the next few months as we see how the transition off certbot-auto goes. With that in mind, I personally would recommend just creating an issue to track cleaning up the code for us to do when we're sure we don't need it. Alternatively, we could do the work now and revert later if needed, but I personally would prioritize other work before this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes certbot/certbot#8358
I followed the same approach than for previous instructions removals, by editing the minimal set of logic required to reach the target, but keeping existing methods and templates.
I think we should make a real clean of the website codebase eventually. If you agree, I can make a PR for it.