Conversation
bmw
left a comment
There was a problem hiding this comment.
Did you get a chance to test this? The changes aren't showing up for me locally.
Also, I think we should hide this warning on CentOS/RHEL 7+ systems. We can do that through the mustache templates you see in this file. Let me know if you'd like a rundown on how this works.
|
Yes I tested it locally, with the Docker I set up in my second PR. Note that it worked once I deleted the jekyll cache. |
|
I tested it by making a branch on this repo containing your code, letting Travis build it and push it here, and then running the site by following my instructions at #443 (comment). The live website is polling the EDIT: Updated link for running built site. |
And the number 1 question I asked when I was in frontend development: did you clear your browser cache? |
bmw
left a comment
There was a problem hiding this comment.
Welp I think my mistake that prevented me from seeing your changes was worse than that. I think I ran the site locally and then connected to https://certbot.eff.org in my browser...
Sorry for the noise!
|
LGTM! I'm going to hold off merging for now until certbot/certbot#7587 is merged or released. |
|
@bmw, #7587 is now merged. |
|
Thanks for the reminder. |
Related to certbot/certbot#7587
Fixes certbot/certbot#7632
Fixes #512
This PR creates an information tooltip on top of RHEL 6 and CentOS 6 sections to warn users that non-x86_64 architectures are not supported by the team for these systems.