Merged
Conversation
This was referenced Mar 7, 2023
Contributor
|
ack, good catch! also thanks for the writeup, i was pretty mystified by the error poetry gave. |
wgreenberg
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#157 fixed the problem locally, but failed on readthedocs. I believe that failure is due to python-poetry/poetry-plugin-export#168.
To fix this, I just unconditionally tightened our Sphinx dependency. While I initially tried not to do this, I don't think it's worth the effort and I really doubt it will be a problem for people. If it is, we can always consider doing something fancier in a followup release. I also changed the minimum version to
4.3.0based on Sphinx's changelog.Unfortunately, that change wasn't enough though because
poetrythen selected an ancient version offlake8that fails on Python 3.7. I fixed this by also specifying a minimum version of that package. The need to keep tracking down minimum versions like this feels somewhat annoying to me, however, in poetry's defense, each solution it presented was valid from its perspective with the dependencies we had specified (until now). I don't think the tigherflake8dependency will be a problem since it's just used for testing.Finally, I tested all of this actually on readthedocs and it passed. See https://readthedocs.org/projects/josepy/builds/19706627/.