Conversation
alexzorin
requested changes
Mar 2, 2023
Collaborator
alexzorin
left a comment
There was a problem hiding this comment.
Works great. That pre-commit project is pretty cool. Just one documentation thing.
CONTRIBUTING.md
Outdated
| # (On Windows Powershell) | ||
| $ .\.venv\Script\activate | ||
| ``` | ||
| 4) Optionally set up [pre-commit](https://pre-commit.com/) |
Collaborator
There was a problem hiding this comment.
I think a short explanation about what this does would be helpful here.
Member
Author
|
I also went ahead and set up pre-commit to just test Thanks so much for all the reviews Alex. |
alexzorin
approved these changes
Mar 2, 2023
This was referenced Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is pretty nice. I've also been considering adding
blackand I'd personally really want this if we start using it.I ran
poetry lockto update things because while it shouldn't matter too much, I wanted to match the versions offlake8andisortused withpre-commitand those inpoetry.lockand the pinned version ofisortdidn't work.