Conversation
alexzorin
approved these changes
Feb 8, 2023
Collaborator
alexzorin
left a comment
There was a problem hiding this comment.
requests-toolbelt is an optional dependency of dnspython though and if it's installed, we hit this warning during our unit tests.
Wow! LGTM, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, if you activate the developer environment and run
pytest certbot/tests/main_test.pytests will fail due to this warning.We haven't been hitting this with
toxbecauserequests-toolbeltisn't installed in those environments. It's in our developer environment becausepoetryandtwinedepends on it.requests-toolbeltis an optional dependency ofdnspythonthough and if it's installed, we hit this warning during our unit tests.