certbot.interfaces: reintroduce empty zope interfaces#9486
certbot.interfaces: reintroduce empty zope interfaces#9486alexzorin merged 2 commits intocertbot:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanks for this PR! Can this be merged, and Certbot v2.1.0 released? |
bmw
left a comment
There was a problem hiding this comment.
From #9485 (comment):
The forum post is a bit wordy, if you can see where places I can cut it down, I'd be glad to shorten it.
It is, however, I feel like it's hard to shorten it without trying to hide the details of what's going on here which I personally don't think we should do. If you wanted, we could call more attention to the actionable steps by making them bold or restructure things a bit maybe by having something like separate "What to do" and "Explanation" sections, but I'm personally fine with the post as it is.
Other than that, I have two suggestions for the content of the post.
- Based on my testing, I think
zope.interface.implementer(interfaces.IPluginFactory)(cls)should bezope.interface.provider(interfaces.IPluginFactory)(cls). - I think it may be nice to link to abc and zope docs on the first usage of these terms.
Otherwise, this LGTM. Thanks so much for working on this Alex.
Fixes #9485.