Skip to content

Add 1.24.x changelog#9234

Merged
bmw merged 3 commits into1.24.xfrom
update-1.24.x-changelog
Mar 14, 2022
Merged

Add 1.24.x changelog#9234
bmw merged 3 commits into1.24.xfrom
update-1.24.x-changelog

Conversation

@bmw
Copy link
Copy Markdown
Member

@bmw bmw commented Mar 14, 2022

See https://opensource.eff.org/eff-open-source/pl/8tepfnrdt7r5jxryz43d6y9z6r for more info.

The changelog says master because it is changed to the current date in the release script. This is what we've done before in PRs like #7511.

Comment on lines +12 to +13
This release was only done for our snaps, however, all of our distribution
mechanisms were updated.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have trouble understanding what the second half of this sentence means. Like, do non-snap users need to care?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This release wouldn't be important to non-snap users, however, I was planning on pushing an update everywhere for simplicity. If you look at b5503e9 or my crossed out text in Mattermost, I was initially planning on limiting the release to snap & docker users, but I'm hesitant to change our release process and do release code in a way we've never done before right before I disappear for a week and a half. We could revisit that plan or we could try to clarify this text to flag that this release is really only useful to our snap users. What do you think?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I misread it as "we're only releasing the snap", rather than "this release was only done [for the sake of] our snaps".

I think clarifying the text would be useful. 👍

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK. Sounds good.

Feel free to offer an alternative if you still don't like the new text.

@bmw bmw merged commit 109634b into 1.24.x Mar 14, 2022
@bmw bmw deleted the update-1.24.x-changelog branch March 14, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants