Conversation
|
Thanks for working on this Adrien. We definitely want this, but I think this would require a new major version of Certbot. I don't want to delay shipping that very long, but we're currently working on other backwards incompatible changes like switching to ECDSA keys by default and I think we should try to do all that in the same release instead of doing 2 new major versions. What do you think about delaying reviewing this until we're ready for Certbot 2.0? |
|
Totally fine with this ! I will keep the PR up to date until it is the time for the new major version. |
fe74d18 to
8a35b2a
Compare
|
I've forced pushed this because there was quite a bit of overlap with #9337 to work around new complaints from pylint and mypy. I've also re-pinned current and oldest dependencies in that commit. After that, only the original commit was really remaining. For when we need the changelog entries again, they were: * Deprecated attributes in `certbot.display.util` are removed.
* `zope` based interfaces in `certbot.interfaces` module are removed.
* `zope` dependencies are removed from Certbot. |
wgreenberg
left a comment
There was a problem hiding this comment.
LGTM! the only thing i noticed were some zopey lines still in .pylintrc, but we shouldn't block merging this on that.
|
Thanks for the rework on my PR @alexzorin and the validation @wgreenberg. Happy to see this moving out of Certbot codebase :) |
|
Sorry @wgreenberg I had to change the base branch so may as well fix the pylintrc thing! |
30c6b7c to
7e79553
Compare
7e79553 to
691fce7
Compare
Zope-related tooling have been deprecated in Certbot 5 months ago.
I propose here to remove this tooling for the next release.
Fixes #8434.
Fixes #8331.