Skip to content

Remove zope from Certbot#9161

Merged
alexzorin merged 2 commits intocertbot:2.0.xfrom
adferrand:remove-zope
Sep 7, 2022
Merged

Remove zope from Certbot#9161
alexzorin merged 2 commits intocertbot:2.0.xfrom
adferrand:remove-zope

Conversation

@adferrand
Copy link
Copy Markdown
Collaborator

@adferrand adferrand commented Jan 6, 2022

Zope-related tooling have been deprecated in Certbot 5 months ago.

I propose here to remove this tooling for the next release.

Fixes #8434.

Fixes #8331.

@bmw bmw self-assigned this Jan 18, 2022
@zoracon zoracon requested a review from bmw January 18, 2022 22:15
@bmw
Copy link
Copy Markdown
Member

bmw commented Jan 21, 2022

Thanks for working on this Adrien. We definitely want this, but I think this would require a new major version of Certbot. I don't want to delay shipping that very long, but we're currently working on other backwards incompatible changes like switching to ECDSA keys by default and I think we should try to do all that in the same release instead of doing 2 new major versions.

What do you think about delaying reviewing this until we're ready for Certbot 2.0?

@adferrand
Copy link
Copy Markdown
Collaborator Author

Totally fine with this ! I will keep the PR up to date until it is the time for the new major version.

@alexzorin alexzorin added this to the 2.0 milestone Apr 26, 2022
@alexzorin alexzorin self-assigned this Jun 2, 2022
@alexzorin alexzorin force-pushed the remove-zope branch 2 times, most recently from fe74d18 to 8a35b2a Compare July 29, 2022 01:11
@alexzorin
Copy link
Copy Markdown
Collaborator

alexzorin commented Jul 29, 2022

I've forced pushed this because there was quite a bit of overlap with #9337 to work around new complaints from pylint and mypy. I've also re-pinned current and oldest dependencies in that commit. After that, only the original commit was really remaining.

For when we need the changelog entries again, they were:

* Deprecated attributes in `certbot.display.util` are removed.
* `zope` based interfaces in `certbot.interfaces` module are removed.
* `zope` dependencies are removed from Certbot.

@zoracon zoracon requested a review from wgreenberg August 25, 2022 21:25
wgreenberg
wgreenberg previously approved these changes Aug 30, 2022
Copy link
Copy Markdown
Collaborator

@wgreenberg wgreenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! the only thing i noticed were some zopey lines still in .pylintrc, but we shouldn't block merging this on that.

@adferrand
Copy link
Copy Markdown
Collaborator Author

Thanks for the rework on my PR @alexzorin and the validation @wgreenberg. Happy to see this moving out of Certbot codebase :)

@alexzorin alexzorin changed the base branch from master to 2.0.x September 1, 2022 21:05
@alexzorin alexzorin dismissed wgreenberg’s stale review September 1, 2022 21:05

The base branch was changed.

@alexzorin
Copy link
Copy Markdown
Collaborator

Sorry @wgreenberg I had to change the base branch so may as well fix the pylintrc thing!

alexzorin
alexzorin previously approved these changes Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate IDisplay interface and/or all of IDisplay Delete reporter.py and IReporter interface

5 participants