Conversation
alexzorin
left a comment
There was a problem hiding this comment.
I gather that PEP440 parsing would be unsuitable for our other purposes (OpenSSL and Fedora version parsing)?
LGTM if so.
|
PEP440 parsing is definitely not suitable for things like OpenSSL. OpenSSL's versioning scheme is described here and strings like We could maybe use PEP440 parsing for things like Apache and Fedora depending on the details of their versioning scheme, but since the previous approach was working, we need something like |
adferrand
left a comment
There was a problem hiding this comment.
The two commits that dismissed @alexzorin's review represent just a technical merge from master, so I assume it is still good to go!
Fixes #9058.
The changes to the CI config are equivalent to the ones made in #8460.
Other than ignoring some warnings raised by botocore, the main additional work that had to be done here was switching away from using
distutils.version.LooseVersionsince the entiredistutilsmodule was deprecated in Python 3.10. To do that, I took a few different approaches:setuptools. This functionality has been available since setuptools 8.0 from 2014.distutils.version.LooseVersionincertbot.util.parse_loose_version.CERTBOT_PIP_NO_BINARYcan be completely removed since that variable isn't used or referenced anywhere in this repo.You can see the full test suite passing on these changes at https://dev.azure.com/certbot/certbot/_build/results?buildId=4645&view=results.
Unless this happens to land in the next few hours which I do not at all expect, the changelog will need to be updated after the release tomorrow.