Skip to content

Pin DNS plugin snap build dependencies#8553

Merged
bmw merged 2 commits intomasterfrom
pin-dns-snap-build-deps
Dec 18, 2020
Merged

Pin DNS plugin snap build dependencies#8553
bmw merged 2 commits intomasterfrom
pin-dns-snap-build-deps

Conversation

@bmw
Copy link
Copy Markdown
Member

@bmw bmw commented Dec 18, 2020

Fixes #8544 by taking the approach in #8443.

You can see tests passing, including for ARM snaps, at https://dev.azure.com/certbot/certbot/_build/results?buildId=3210&view=results.

To ensure things were working as expected, I pinned a nonexistent version of setuptools causing the builds to fail which you can see at https://dev.azure.com/certbot/certbot/_build/results?buildId=3212&view=results.

Copy link
Copy Markdown
Collaborator

@adferrand adferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmw bmw merged commit e9bdfcc into master Dec 18, 2020
@bmw bmw deleted the pin-dns-snap-build-deps branch December 18, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin build dependencies in plugin snaps

2 participants