Merged
Conversation
* Completely deprecate certbot-auto * DeaDeactivate centos6/oraclelinux6 tests * Remove tests assets * Remove another test * Revert "Remove tests assets" This reverts commit e603afe.
* Don't deprecate certbot-auto quite yet * Remove centos6 test farm tests * undo changes to test farm test scripts
alexzorin
previously requested changes
Dec 2, 2020
Collaborator
alexzorin
left a comment
There was a problem hiding this comment.
There are some unit tests and fixtures related to CentOS 6 remaining in certbot-apache.
Did you want to remove those separately?
Collaborator
In #8489 I did not remove them (and several useless code from certbot-auto) to avoid having too much big PRs and avoid unexpected failures. |
Member
Author
|
Yes I would like to do that later. I think removing support for CentOS 6 (and Apache 2.2 more generally) requires a new major release of Certbot and I think we should keep the code testing it around until we've removed the user facing code in the plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8490.
Adrien had already done most of this in #8489, but that PR contains other changes that we wouldn't want to add the the point release branch. Because of this, I started with his work in that PR, squashed the commits, and cleaned things up.
This PR should be merged and not squashed to preserve authorship.
You can see tests passing with these changes https://dev.azure.com/certbot/certbot/_build/results?buildId=3094&view=results.