add support for CNAME challenge alias with route53#7884
add support for CNAME challenge alias with route53#7884bobcarroll wants to merge 1 commit intocertbot:mainfrom
Conversation
|
Thanks for the PR @rcarz. It looks like some of our tests are failing which would need to be fixed before this is merged, but to set expectations here, this probably won't be reviewed for a while. There is a definite need for this feature, but we're hoping to rethink our approach to DNS challenges in Certbot in the next year and any code like this complicates the transition to a new system without breaking things. Because of that, I think we'll probably at least finish our design tackling issues like #6464, #6503, and #6504 before making a decision on PRs like this one. I'm sure that's not what you wanted to hear, but I think it's the best decision for us in the medium/long term. I'll leave this PR open since we may well accept it once we have figured out the approach to DNS challenges we want to take in the long term. |
This PR adds support for challenge aliases to the dns-route53 plugin. These changes are a lot more narrow in scope than #6644 and were meant to service an immediate need while a more generalized solution is discussed.
Pull Request Checklist
mastersection ofcertbot/CHANGELOG.mdto include a description of the change being made.AUTHORS.mdif you like.Fixes #6566