Skip to content

Dns rfc2136 zone#7346

Open
drdivano wants to merge 3 commits intocertbot:mainfrom
drdivano:dns-rfc2136-zone
Open

Dns rfc2136 zone#7346
drdivano wants to merge 3 commits intocertbot:mainfrom
drdivano:dns-rfc2136-zone

Conversation

@drdivano
Copy link
Copy Markdown

Zone detection logic _find_domain didn't work for me, so I added an option to explicitly provide zone name. Please review the code. If the general approach is ok, I can add the docs.

@bmw
Copy link
Copy Markdown
Member

bmw commented Aug 22, 2019

I think this is a duplicate of #6644 and #7244 right?

@bmw bmw self-assigned this Aug 22, 2019
@drdivano
Copy link
Copy Markdown
Author

I think this is a duplicate of #6644 and #7244 right?

It looks similar, but I think my case is distinct.

I have BIND zone file for my domain (example.com) under version control.

I add a separate zone file containing a TXT record for ACME challenge (_acme-challenge.example.com) and set up keys and permissions in BIND to be able to modify it via rfc2136 protocol.

Since domain name in SOA record in BIND can't have underscores, I can't put _acme-challenge.example.com in SOA, and therefore certbot can't correctly deduce the domain from SOA.

@bmw
Copy link
Copy Markdown
Member

bmw commented Aug 23, 2019

Thanks for the additional info.

@adferrand or @joohoi, I think you both know more about this than me. When you get a few minutes, can you comment on this use case and whether or not it would be supported by the two PRs I reference above?

@adferrand
Copy link
Copy Markdown
Collaborator

I think this situation is one of the pathological cases described by @hpax in #7244.

Here _acme-challenge.example.com is a zone on its own described out of the scope of the DNS server declared as SOA for the example.com zone. Typically a situation where recursive discovery will not work.

So I think having a flag to explicitly set the zone name is a good complement to override any auto discovery result if needed, or circumvent the inability to use the auto discovery.

Finally, if #7244 lands as a more generic implementation for any dns provider, this one should be generalized as well. If not, we can keep it for the sole purpose of rfc2136 plugin.

@bmw bmw added the area: dns label Feb 18, 2020
@bmw bmw changed the base branch from master to main February 10, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants