Conversation
Contributor
Author
|
@ohemorange, I've just merged this with the current master branch and I think @g6123 had actually satisfied all of our outstanding substantive requests on the PR. Can you think of other things that need to be changed or improved? |
ohemorange
requested changes
Feb 1, 2019
Contributor
ohemorange
left a comment
There was a problem hiding this comment.
Noticed that the last commit added some code that doesn't have a test, let's put in a test for that and then get this in.
| return nginxparser.load(_file) | ||
| except IOError: | ||
| logger.warning("Missing NGINX TLS options file: %s", ssl_options) | ||
| except UnicodeDecodeError: |
Contributor
There was a problem hiding this comment.
This code needs coverage
Contributor
|
@schoen this PR is so close! when do you think you'll get a chance to finish it up? |
Contributor
|
Hey @schoen, any chance we could finish this up? |
Contributor
|
Bumping on this |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on and supersedes #5341.
Fixes #5337.