Skip to content

Apache and Nginx plugins should use reload rather than restart #954

@jsha

Description

@jsha

letsencrypt-apache/letsencrypt_apache/configurator.py

.. todo:: Try to use reload instead. (This caused timing problems before)                                                                                                    

Our challenge methods are designed to be used without taking down a web server, so we should make sure we actually don't take down the web server to restart.

Note that Nginx has this issue too, noted in #950 and worked around.

We need a generic wait_for_challenge method that can be used for both plugins, which will repeatedly attempt to connect to the appropriate port on localhost and ask for the appropriate servername. If the loop times out after, say, five seconds, it should error out and say the configuration to add the challenge failed.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions