-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Run lint on our tests again #7908
Copy link
Copy link
Closed as not planned
Labels
area: code healtharea: testingarea: toolingneeds-updatepriority: significantIssues with higher than average priority that do not need to be in the current milestone.Issues with higher than average priority that do not need to be in the current milestone.
Metadata
Metadata
Assignees
Labels
area: code healtharea: testingarea: toolingneeds-updatepriority: significantIssues with higher than average priority that do not need to be in the current milestone.Issues with higher than average priority that do not need to be in the current milestone.
When we moved our tests out of our packages, we accidentally stopped running
pylinton them. Unfortunately, this isn't an entirely trivial fix.pylintdoes not support running tests on all files in a directory that's not part of a package. See pylint-dev/pylint#352.At least a few ways to fix this are:
pylintthe path to each individual file intestsdirectories. This is tricky becausetestsmay contain arbitrary subdirectories.testsdirectories modules by adding__init__.py. My understanding is this is not normally done and I am not sure if there are any downsides to do this.flake8which happily will run tests on all files in subdirectories.I'm personally most excited by the last option although it is almost certainly the most work.