Skip to content

Document custom annotation behaviour#1501

Merged
cert-manager-prow[bot] merged 2 commits into
cert-manager:release-nextfrom
AbsaOSS:ingress_shim_annotations
Apr 29, 2025
Merged

Document custom annotation behaviour#1501
cert-manager-prow[bot] merged 2 commits into
cert-manager:release-nextfrom
AbsaOSS:ingress_shim_annotations

Conversation

@k0da

@k0da k0da commented Jun 9, 2024

Copy link
Copy Markdown
Contributor

@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2024
@netlify

netlify Bot commented Jun 9, 2024

Copy link
Copy Markdown

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 9eb682c
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6665ab3f7be51c0008b5e19e
😎 Deploy Preview https://deploy-preview-1501--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@erikgb

erikgb commented Apr 8, 2025

Copy link
Copy Markdown
Member

@k0da Are you able to brush up this PR with how this new feature ended up being merged? 🙏

@k0da k0da force-pushed the ingress_shim_annotations branch from 9eb682c to 7eb446d Compare April 8, 2025 21:53
@k0da

k0da commented Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

@erikgb Sure. I changed wording a little bit. I guess CLI flags are automatically generated?

@netlify

netlify Bot commented Apr 8, 2025

Copy link
Copy Markdown

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5c313bb
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/6810c425732430000844663c
😎 Deploy Preview https://deploy-preview-1501--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

For feature: cert-manager/cert-manager#7083

Signed-off-by: Dinar Valeev <k0da@opensuse.org>
@k0da k0da force-pushed the ingress_shim_annotations branch from 7eb446d to cb3e684 Compare April 29, 2025 11:20
@k0da k0da changed the base branch from master to release-next April 29, 2025 11:20
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@cert-manager-prow cert-manager-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2025

@wallrj wallrj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this new feature @k0da

And thanks for taking the time to document it!

/approve
/lgtm

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2025
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@cert-manager-prow cert-manager-prow Bot merged commit 59e6296 into cert-manager:release-next Apr 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants