Skip to content

Improve OtherNames Release notes#1408

Merged
jetstack-bot merged 1 commit intocert-manager:release-nextfrom
wallrj:release-notes-tweaks-1
Feb 1, 2024
Merged

Improve OtherNames Release notes#1408
jetstack-bot merged 1 commit intocert-manager:release-nextfrom
wallrj:release-notes-tweaks-1

Conversation

@wallrj
Copy link
Copy Markdown
Member

@wallrj wallrj commented Feb 1, 2024

Signed-off-by: Richard Wall <richard.wall@venafi.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 1, 2024

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit c48e9f6
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65bbb4d54d7d9900080590b8
😎 Deploy Preview https://deploy-preview-1408--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@hawksight hawksight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@hawksight
Copy link
Copy Markdown
Member

/approve

1 similar comment
@wallrj
Copy link
Copy Markdown
Member Author

wallrj commented Feb 1, 2024

/approve

@hawksight
Copy link
Copy Markdown
Member

I cannot approve, but I tested the links as working and it does correctly now say "OtherNames" :)

@jetstack-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawksight, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@jetstack-bot jetstack-bot merged commit 8c1fce6 into cert-manager:release-next Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants