docs: Revise release note for profile option and add example to the certificate usage section#1407
Merged
jetstack-bot merged 4 commits intocert-manager:release-nextfrom Feb 1, 2024
Merged
Conversation
…ertificate usage section Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wallrj
approved these changes
Feb 1, 2024
Member
wallrj
left a comment
There was a problem hiding this comment.
Thanks Peter.
I spotted a typo by otherwise lgtm.
content/docs/usage/certificate.md
Outdated
| # if you are using an external issuer, change this to that issuer group. | ||
| group: cert-manager.io | ||
|
|
||
| # keystores allows additing additional output formats. This is an example reference only. |
Member
There was a problem hiding this comment.
Suggested change
| # keystores allows additing additional output formats. This is an example reference only. | |
| # keystores allows adding additional output formats. This is an example for reference only. |
wallrj
reviewed
Feb 1, 2024
|
|
||
| There is a new option `.spec.keystores.pkcs12.algorithms` to specify encryption and MAC algorithms for PKCS. | ||
| There is a new option `.spec.keystores.pkcs12.profile` to specify encryption and HMAC algorithms for PKCS keystores. | ||
| See the [API reference](../../../docs/reference/api-docs/#cert-manager.io/v1.PKCS12Profile) for configuration options. |
Member
There was a problem hiding this comment.
I think you need to link to the markdown document. See:
website/content/docs/configuration/acme/http01/README.md
Lines 51 to 53 in f91577c
Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
…the url Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1406.
/cc @wallrj