Improve + fix signature verification examples#1389
Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom Jan 15, 2024
Merged
Improve + fix signature verification examples#1389jetstack-bot merged 1 commit intocert-manager:masterfrom
jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
inteon
reviewed
Jan 15, 2024
Member
inteon
left a comment
There was a problem hiding this comment.
Thanks for fixing this error on the website.
/approve
/lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current examples don't work, so there's a need to fix that with ignoring the tlog.
As a bonus, this removes the need to download the key locally since cosign will happily download it for us!