Skip to content

Add GlobalSign Atlas Issuer#1382

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
PrashantGSIN:6-atlas-issuer
Jan 11, 2024
Merged

Add GlobalSign Atlas Issuer#1382
jetstack-bot merged 1 commit intocert-manager:masterfrom
PrashantGSIN:6-atlas-issuer

Conversation

@PrashantGSIN
Copy link
Copy Markdown

GlobalSign is an external issuer of cert-manager that offers GlobalSign's TLS certificates. You can download the Production ready CRD of Cert-manager of GlobalSign from https://github.com/globalsign/atlas-cert-manager to secure your kubernetes Cluster.

It is developed and maintained by GlobalSign Team and currently uses the Cert-manager Version 1.13.1. For more understanding, you can read the documentation of it at https://github.com/globalsign/atlas-cert-manager/blob/master/README.md

After Installation of the GlobalSign's Certmanager CRD. you can request for Atlas credentials to configure GlobalSign-atlas-issuer in your kubernetes environment to get TLS certificates for your needs

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 11, 2024

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit ed3d0f4
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/659fe43227b1c40007bfc56e
😎 Deploy Preview https://deploy-preview-1382--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wallrj wallrj changed the title --signed-off-by: Prashant.Antil@GlobalSign.com Add GlobalSign Atlas Issuer Jan 11, 2024
@wallrj wallrj self-requested a review January 11, 2024 10:38
@wallrj wallrj mentioned this pull request Jan 11, 2024
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2024
Signed-off-by: Prashant Antil <Prashant.Antil@GlobalSign.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 11, 2024
Copy link
Copy Markdown
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PrashantGSIN I rebased your PR and force pushed the updates to your branch.

/lgtm
/approve

| 🥈 | command-issuer | [📄][config:command-issuer] | [Keyfactor Command][ca:command-issuer] | - | [✔️][release:command-issuer] | ✔️ |
| 🥈 | ejbca-issuer | [📄][config:ejbca-issuer] | [EJBCA][ca:ejbca-issuer] | - | [✔️][release:ejbca-issuer] | ✔️ |
| 🥈 | google-cas-issuer | [📄][config:google-cas-issuer] | [Google Cloud Certificate<br/>Authority Service][ca:google-cas-issuer] | - | [✔️][release:google-cas-issuer] | ✔️ |
| 🥈 | gs-atlas-issuer | [📄][config:gs-atlas-issuer] | [GlobalSign CA][ca:gs-atlas-issuer] | - | [✔️][release:gs-atlas-issuer] | ✔️ |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed your issuer from tier-1 to tier-2 because I couldn't find an E2E tutorial for it.
For tier-1 there should be an up to date tutorial somewhere. Perhaps in the GlobalSign Atlas documentation:

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@jetstack-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@jetstack-bot jetstack-bot merged commit 32be526 into cert-manager:master Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants