Skip to content

adding new version of adcs-issuer#1369

Merged
jetstack-bot merged 2 commits intocert-manager:masterfrom
djkormo:patch-1
Dec 20, 2023
Merged

adding new version of adcs-issuer#1369
jetstack-bot merged 2 commits intocert-manager:masterfrom
djkormo:patch-1

Conversation

@djkormo
Copy link
Copy Markdown
Contributor

@djkormo djkormo commented Dec 19, 2023

Adding new version of adcs-issuer

Signed-off-by: Krzysztof Pudłowski <djkormo@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 19, 2023
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 19, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 505162a
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65834898d1205600085f6cd6
😎 Deploy Preview https://deploy-preview-1369--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for maintaining this issuer!
I'm also very happy that we can move this issuer to tier 2.
@djkormo would it be possible to order the issuers alphabetically within tier 2?

Signed-off-by: Krzysztof Pudłowski <djkormo@gmail.com>
@djkormo
Copy link
Copy Markdown
Contributor Author

djkormo commented Dec 20, 2023

Added order the issuers alphabetically within tier 2

Copy link
Copy Markdown
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for maintaining and sharing this issuer.

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@jetstack-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
@jetstack-bot jetstack-bot merged commit 6f7759a into cert-manager:master Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants