Webhook troubleshooting: advise people to set timeoutSeconds to 30 seconds#1199
Conversation
1c52767 to
3b31bbb
Compare
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Maël Valais <mael@vls.dev>
3b31bbb to
73f7d9e
Compare
wallrj
left a comment
There was a problem hiding this comment.
I noticed some typos.
I suggest changing the default timeout in the cert-manager Helm chart.
Is there any reason not to do that?
This documentation can still be merged for the benefit of users of older versions of cert-manager.
Signed-off-by: Richard Wall <wallrj@users.noreply.github.com>
Signed-off-by: Richard Wall <wallrj@users.noreply.github.com>
wallrj
left a comment
There was a problem hiding this comment.
I applied the fixes for typos.
As mentioned earlier, in 1.14 (due for release on Jan 31 2024) the default will be 30seconds, so this documentation may need updating again.
- cert-manager/cert-manager#6488
- https://github.com/cert-manager/cert-manager/releases/tag/v1.14.0-alpha.1
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The message
context deadline exceededis entirely useless when trying to debug it, and one of the main reasons this message appear is that our own Helm chart configures the "context" timeout to 10 seconds in values.yaml.