Use controller-gen to generate applyconfigurations#657
Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:mainfrom Jul 17, 2025
Merged
Use controller-gen to generate applyconfigurations#657cert-manager-prow[bot] merged 1 commit intocert-manager:mainfrom
cert-manager-prow[bot] merged 1 commit intocert-manager:mainfrom
Conversation
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using applyconfiguration-gen directly, it is now possible to do it using controller-gen. This will enable us to remove the applyconfiguration-gen version configuration from makefile-modules.
I would also like to "promote" this to the makefile-modules controller-gen module, which will enable applyconfiguration generation to all our projects.
This will enable us to resolve cert-manager/cert-manager#5783 and also migrate away from the deprecated fake
NewSimpleClientSetfunctions.I am removing the generated applyconfigurations for the new (and unpublished) API. It was a mistake to add them previously, as the new API is not yet available. With the current approach for generating, this was hard to avoid. But now we can control this with markers in code.