fix(deps): upgrade Kubernetes to 1.34 #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inteon
reviewed
Sep 2, 2025
| - example.cert-manager.2 | ||
| duration: 24h0m0s | ||
| issuerRef: | ||
| group: cert-manager.io |
Member
There was a problem hiding this comment.
I wonder if there exists a tool that drops these fields if the defaults in the versions match.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: cert-manager-bot <cert-manager-bot@users.noreply.github.com>
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
Member
Author
|
@inteon, somehow I had a conflict in go.sum, so I need another LGTM. |
Member
Author
|
@inteon Are you able to provide this PR with a new LGTM? |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cherry-pick of #286, but with an additional commit to use a pseudo-version of cert-manager for now, ref. cert-manager/cert-manager#8018.
Some changes in the cert-manager Go API required adjustments here, so please review those parts carefully.
/cc @inteon @wallrj