Skip to content

Conversation

@wallrj
Copy link
Member

@wallrj wallrj commented Jul 10, 2025

In cert-manager/makefile-modules#306 I updated goreleaser to v2

In this PR I'm pulling in those updated modules using klone and updating the .goreleaser.yaml file to be compatible with version 2.

goreleaser v2 references:

Testing

I created a test release:

I tested the resulting cmctl binary as follows:

curl -fsSL -O https://github.com/cert-manager/cmctl/releases/download/v2.3.0-alpha.1/cmctl_linux_amd64
chmod +x cmctl_linux_amd64
mv cmctl_linux_amd64 ~/.local/bin/
kind create cluster
cmctl x install
cmctl version -o yaml
clientVersion:
  compiler: gc
  gitCommit: 262bd50637c41abdf37bf3821472a62f318f225f
  gitTreeState: ""
  gitVersion: v2.3.0-alpha.1
  goVersion: go1.24.5
  platform: linux/amd64
serverVersion:
  detected: v1.18.2
  sources:
    crdLabelVersion: v1.18.2

@cert-manager-prow cert-manager-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2025
@cert-manager-prow cert-manager-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2025
@cert-manager-prow cert-manager-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2025
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@wallrj wallrj changed the title WIP: Update goreleaser to v2 Update goreleaser to v2 Jul 11, 2025
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2025
@wallrj wallrj requested a review from inteon July 11, 2025 06:32
@wallrj wallrj changed the title Update goreleaser to v2 Use goreleaser v2 Jul 11, 2025
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025
@cert-manager-prow cert-manager-prow bot merged commit 1663c3b into main Jul 11, 2025
5 checks passed
@wallrj wallrj deleted the goreleaser-v2 branch July 11, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants