Skip to content

Conversation

@erikgb
Copy link
Member

@erikgb erikgb commented Apr 7, 2025

It seems like #198 needs a bit of help. Mainly because new fields are added to cert-manager API. All the new fields are optional (as they should be), and the simplest solution to still use the generated conversion code is to just add the new field to older API versions.

Also forced to fix some leftover migrations to structured logging.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2025
@erikgb erikgb force-pushed the bump-cert-manager branch from 28b8de2 to 5317fc4 Compare April 7, 2025 16:15
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb erikgb force-pushed the bump-cert-manager branch from 5317fc4 to ea5e56e Compare April 7, 2025 16:21
@erikgb erikgb requested a review from inteon April 7, 2025 16:29
@inteon
Copy link
Member

inteon commented Apr 7, 2025

/lgtm
/approve
Thank you for fixing the issues!

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 7, 2025
@cert-manager-prow cert-manager-prow bot merged commit 1f011eb into cert-manager:main Apr 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants