Skip to content

Move old API definitions into this repo #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cert-manager-prow merged 1 commit into from
Oct 17, 2024
Merged

Move old API definitions into this repo #121

cert-manager-prow merged 1 commit into from
Oct 17, 2024

Conversation

@inteon
Copy link
Member

@inteon inteon commented Sep 18, 2024 •
edited
Loading

We removed the deprecated cert-manager APIs from the cert-manager/cert-manager repo (see cert-manager/cert-manager#7278).
Now, we have to move them to this repo so we can keep using them in the convert command.

The API versions that we moved are:

(acme.)cert-manager.io/v1alpha2
(acme.)cert-manager.io/v1alpha3
(acme.)cert-manager.io/v1beta1

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 18, 2024
@inteon inteon force-pushed the move_old_apis branch 2 times, most recently from 59dd104 to dc0897d Compare September 18, 2024 10:03
@inteon inteon closed this Sep 18, 2024
@inteon inteon reopened this Sep 18, 2024
@inteon inteon mentioned this pull request Sep 18, 2024
Merged
@inteon inteon force-pushed the move_old_apis branch 2 times, most recently from 82d275a to 5ae8e68 Compare September 23, 2024 08:23
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2024
@inteon
move old API defintions to this repo
28b7927 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2024
@inteon inteon changed the title Move old API definitions to this repo Move old API definitions into this repo Oct 7, 2024
SgtCoDFish
SgtCoDFish approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Discussed in biweekly - approving without much of a review because the process was explained. If followups are needed obviously we can review those!

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2024
@cert-manager-prow cert-manager-prow bot merged commit 3d14790 into cert-manager:main Oct 17, 2024
@BrewTestBot BrewTestBot mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@inteon @SgtCoDFish