Skip to content
This repository was archived by the owner on Jun 20, 2025. It is now read-only.

Release 1.13#99

Merged
wallrj merged 4 commits intocert-manager:masterfrom
wallrj:release-1.13
Oct 5, 2023
Merged

Release 1.13#99
wallrj merged 4 commits intocert-manager:masterfrom
wallrj:release-1.13

Conversation

@wallrj
Copy link
Copy Markdown
Member

@wallrj wallrj commented Oct 3, 2023 •
edited
Loading

RC1

I messed up the -rc1 release by forgetting to remove the stable channel from the BUNDLE_CHANNELS value in the Makefile:

This has resulted in the -rc1 package being published to the stable channel:

The release pipeline for RedHat OpenShift OperatorHub seems to have hung so perhaps I'm lucky I can quickly create the stable release and RedHat OpenShift users won't find that their cert-manager got updated to the -rc1 vesion.

In any case, the -rc1 version seems to have passed the subset of E2E tests that I normally run:

$ git checkout b12644b9aaef73ffef0bd58b545141ebe0eb63d1
Previous HEAD position was a7ea746ce Merge pull request #6372 from inteon/release-1.12_base_images
HEAD is now at b12644b9a Merge pull request #6000 from SgtCoDFish/boilersuite

$ make e2e-build
cd _bin/tools/ && ln -f -s ../downloaded/tools/_go-1.20.3-linux-amd64/goroot .
cd _bin/tools/ && ln -f -s ../downloaded/tools/_go-1.20.3-linux-amd64/goroot/bin/go .
cd _bin/tools/ && ln -f -s ../downloaded/tools/ginkgo@v2.7.0_linux_amd64 ginkgo
/home/richard/projects/cert-manager/cert-manager/_bin/tools/ginkgo build --tags e2e_test test/e2e
Compiled e2e.test
mv test/e2e/e2e.test _bin/test/e2e.test

$  ./_bin/test/e2e.test --repo-root=/dev/null --ginkgo.focus="CA\ Issuer" --ginkgo.skip="Gateway"
Running Suite: cert-manager e2e suite - /home/richard/projects/cert-manager/cert-manager
========================================================================================
Random Seed: 1696350835

Will run 44 of 839 specs
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS••••SSS••••••••••••••••••SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

Ran 23 of 839 Specs in 44.104 seconds
SUCCESS! -- 23 Passed | 0 Failed | 0 Pending | 816 Skipped
PASS

ℹ️ I have to check out the commit of cert-manager before cert-manager/cert-manager#5950 got merged, because that PR tries to install Hashicorp vault in the cluster, despite me not running the Vault tests, and it uses a locally compiled Docker image which is difficult to build and push to the OpenShift cluster.

ℹ️ I ran the E2E tests on a vanilla Kind Kubernetes cluster rather than a CRC OpenShift cluster, because the https://github.com/redhat-openshift-ecosystem/community-operators-prod/actions/runs/6394960291 pipeline seems to be stuck.

Final Release

Testing

Installed on OpenShift 4.13
image

Ran CA Issuer E2E tests

$ make crc-e2e E2E_TEST=../cert-manager/_bin/test/e2e.test
: ${E2E_TEST:?"Please set E2E_TEST to the path to the cert-manager E2E test binary"}
gcloud compute ssh crc@crc-4-13 -- rm -f ./e2e
gcloud compute scp --compress ../cert-manager/_bin/test/e2e.test crc@crc-4-13:e2e
gcloud compute ssh crc@crc-4-13 -- ./e2e --repo-root=/dev/null --ginkgo.focus="CA\ Issuer" --ginkgo.skip="Gateway"
Connection to 34.140.125.216 closed.
e2e.test                                                                                  100%   44MB  25.3MB/s   00:01
Running Suite: cert-manager e2e suite - /home/crc
=================================================
Random Seed: 1696501581

Will run 44 of 777 specs
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS••••SSS•[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
Detected at:
        >  goroutine 359 [running]:
        >  runtime/debug.Stack()
        >       runtime/debug/stack.go:24 +0x5e
        >  sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
        >       sigs.k8s.io/controller-runtime@v0.16.2/pkg/log/log.go:60 +0xcd
        >  sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).WithName(0xc000051f40, {0x1da59ee, 0x14})
        >       sigs.k8s.io/controller-runtime@v0.16.2/pkg/log/deleg.go:147 +0x45
        >  github.com/go-logr/logr.Logger.WithName({{0x206fd10, 0xc000051f40}, 0x0}, {0x1da59ee?, 0xc000a87d98?})
        >       github.com/go-logr/logr@v1.2.4/logr.go:336 +0x3d
        >  sigs.k8s.io/controller-runtime/pkg/client.newClient(0x0?, {0x0, 0xc0001fdea0, {0x0, 0x0}, 0x0, {0x0, 0x0}, 0x0})
        >       sigs.k8s.io/controller-runtime@v0.16.2/pkg/client/client.go:122 +0xec
        >  sigs.k8s.io/controller-runtime/pkg/client.New(0x1dc0036?, {0x0, 0xc0001fdea0, {0x0, 0x0}, 0x0, {0x0, 0x0}, 0x0})
        >       sigs.k8s.io/controller-runtime@v0.16.2/pkg/client/client.go:103 +0x7d
        >  github.com/cert-manager/cert-manager/e2e-tests/framework.(*Framework).BeforeEach(0xc00023b7c0)
        >       github.com/cert-manager/cert-manager/e2e-tests/framework/framework.go:145 +0x33c
        >  github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3({0xa01948, 0xc000700600})
        >       github.com/onsi/ginkgo/v2@v2.12.0/internal/node.go:463 +0x13
        >  github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
        >       github.com/onsi/ginkgo/v2@v2.12.0/internal/suite.go:865 +0x8d
        >  created by github.com/onsi/ginkgo/v2/internal.(*Suite).runNode in goroutine 12
        >       github.com/onsi/ginkgo/v2@v2.12.0/internal/suite.go:852 +0xd7b
•••••••••••••••••SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

Ran 23 of 777 Specs in 88.384 seconds
SUCCESS! -- 23 Passed | 0 Failed | 0 Pending | 754 Skipped
PASS
Connection to 34.140.125.216 closed.

@wallrj
v1.13.1-rc1
5180908 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Oct 3, 2023
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wallrj. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 3, 2023
@wallrj
make bundle-generate
a9e9e4d 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
wallrj added 2 commits October 3, 2023 17:49
@wallrj
v1.13.1
5b550f6 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj
make bundle-generate
b249773 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj
Copy link
Copy Markdown
Member Author

wallrj commented Oct 4, 2023 •
edited
Loading

Blocked by

Update: RedHat fixed the bug and the v1.13.1 package now appears on OpenShift OperatorHub web UI.

@wallrj wallrj mentioned this pull request Oct 4, 2023
Merged
@wallrj wallrj merged commit 8cad90d into cert-manager:master Oct 5, 2023
@wallrj wallrj deleted the release-1.13 branch October 5, 2023 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wallrj @jetstack-bot