Skip to content

make http01 solver pod resource request/limits configurable, refs #892#923

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
arnisoph:issue892
Oct 10, 2018
Merged

make http01 solver pod resource request/limits configurable, refs #892#923
jetstack-bot merged 1 commit intocert-manager:masterfrom
arnisoph:issue892

Conversation

@arnisoph
Copy link
Copy Markdown
Contributor

@arnisoph arnisoph commented Sep 26, 2018 •
edited
Loading

What this PR does / why we need it:
Makes the values configurable that have been hardcoded/introduced via #408

Which issue this PR fixes:
It refs #892 but doesn't necessarily fixes it.

Special notes for your reviewer:

Release note:

Make http01 solver pod resource request/limits configurable

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2018
@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 26, 2018
@arnisoph
Copy link
Copy Markdown
Contributor Author

arnisoph commented Sep 26, 2018

/assign @munnerz

@kragniz
Copy link
Copy Markdown
Member

kragniz commented Sep 26, 2018

/ok-to-test

@jetstack-bot jetstack-bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 26, 2018
@arnisoph
make http01 solver pod resource request/limits configurable, refs cer…
845eb7f 
…t-manager#892

Signed-off-by: Arnold Bechtoldt <arnold.bechtoldt@inovex.de>
@arnisoph
Copy link
Copy Markdown
Contributor Author

arnisoph commented Sep 26, 2018

/retest

@arnisoph
Copy link
Copy Markdown
Contributor Author

arnisoph commented Sep 26, 2018

Can someone explain me that (https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_cert-manager/923/pull-cert-manager-e2e-v1-11/173/) error please?

@arnisoph
Copy link
Copy Markdown
Contributor Author

arnisoph commented Sep 26, 2018

🎉 hooray! tests successful

@arnisoph
Copy link
Copy Markdown
Contributor Author

arnisoph commented Oct 5, 2018

Could someone please take care of this PR? Thanks :)

@munnerz
Copy link
Copy Markdown
Member

munnerz commented Oct 10, 2018

Hey, thanks very much for this PR and sorry it's not been looked at sooner. It has been a busy few weeks!

This looks great, and I think we can merge this as-is 😄 thanks very much for getting those tests passing, and I hope it wasn't too painful!

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2018
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Oct 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2018
@jetstack-bot jetstack-bot merged commit 5ea95b6 into cert-manager:master Oct 10, 2018
@arnisoph arnisoph deleted the issue892 branch October 10, 2018 12:16
@munnerz munnerz mentioned this pull request Nov 21, 2018
Closed
@mbin-azhar
Copy link
Copy Markdown

mbin-azhar commented Dec 27, 2024 •
edited
Loading

Hey, this doesn't work anymore because of https://github.com/cert-manager/cert-manager/blob/master/cmd/controller/app/options/options.go#L110 right? Or am I getting it confused with something else?

If so, is there another way to enforce resource requests/limits to solver pods? @munnerz @arnisoph

@lunarwhite lunarwhite mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kragniz kragniz Awaiting requested review from kragniz

Assignees

@munnerz munnerz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arnisoph @kragniz @munnerz @jetstack-bot @mbin-azhar