Skip to content

Simplify finalizer logic & remove useless test#8521

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
inteon:challenge_finalizer_cleanup
Feb 17, 2026
Merged

Simplify finalizer logic & remove useless test#8521
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
inteon:challenge_finalizer_cleanup

Conversation

@inteon
Copy link
Copy Markdown
Member

@inteon inteon commented Feb 17, 2026

Finalizer handling logic cleanup in preparation for #8519.

Kind

/kind cleanup

Release Note

NONE

@cert-manager-prow cert-manager-prow bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/acme Indicates a PR directly modifies the ACME Issuer code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2026
erikgb
erikgb reviewed Feb 17, 2026
View reviewed changes
@inteon inteon force-pushed the challenge_finalizer_cleanup branch from 88e4db9 to dbf867d Compare February 17, 2026 16:30
@inteon
simplify finalizer logic & remove useless tests
45c14f7 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon force-pushed the challenge_finalizer_cleanup branch from dbf867d to 45c14f7 Compare February 17, 2026 16:34
@inteon inteon mentioned this pull request Feb 17, 2026
Merged
erikgb
erikgb reviewed Feb 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2026
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Feb 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2026
@inteon
Copy link
Copy Markdown
Member Author

inteon commented Feb 17, 2026

/check-dco

@cert-manager-prow cert-manager-prow bot merged commit 45446ac into cert-manager:master Feb 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikgb erikgb erikgb left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@inteon @erikgb