Skip to content

[release-1.18] fix(acme/http01): solver mishandles host headers containing an IPv6 address without a port number#8437

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:release-1.18from
cert-manager-bot:cherry-pick-8424-to-release-1.18
Jan 23, 2026
Merged

[release-1.18] fix(acme/http01): solver mishandles host headers containing an IPv6 address without a port number#8437
cert-manager-prow[bot] merged 1 commit intocert-manager:release-1.18from
cert-manager-bot:cherry-pick-8424-to-release-1.18

Conversation

@cert-manager-bot
Copy link
Copy Markdown
Contributor

@cert-manager-bot cert-manager-bot commented Jan 22, 2026 •
edited by SgtCoDFish
Loading

This is an automated cherry-pick of #8424

/assign SgtCoDFish

Fixed an issue where HTTP-01 challenges failed when the Host header contains an IPv6 address. This means that users can now issue IP address certificates for IPv6 address subjects.

@SlashNephy
fix(HTTP-01): handling of IPv6 address literals
ba0117b 
For IPv6 addresses, the Host header may contain square brackets

Signed-off-by: SlashNephy <slashnephy@hatena.ne.jp>
@cert-manager-bot cert-manager-bot mentioned this pull request Jan 22, 2026
Merged
@cert-manager-prow cert-manager-prow bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2026
@SgtCoDFish
Copy link
Copy Markdown
Member

SgtCoDFish commented Jan 22, 2026

/kind bug

@cert-manager-prow cert-manager-prow bot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 22, 2026
SgtCoDFish
SgtCoDFish approved these changes Jan 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2026
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2026
@cert-manager-prow cert-manager-prow bot merged commit 5a6ef3d into cert-manager:release-1.18 Jan 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cert-manager-bot @SgtCoDFish @SlashNephy