Design: Image config Helm Chart (Introduction of 2 additional Helm Values)#8425
Conversation
|
Hi @FelixPhipps. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
SgtCoDFish
left a comment
There was a problem hiding this comment.
Few minor bits, but I like the direction of this!
SgtCoDFish
left a comment
There was a problem hiding this comment.
Couple more bits from me - I think this is close!
| imageRegistry: private-registry.venafi.cloud | ||
| imageNamespace: cert-manager |
There was a problem hiding this comment.
suggestion: The implication of removing the suffix option from this design is that this would need to be:
| imageRegistry: private-registry.venafi.cloud | |
| imageNamespace: cert-manager | |
| imageRegistry: private-registry.venafi.cloud | |
| imageNamespace: cert-manager | |
| image: | |
| name: cert-manager-controller-fips | |
| acmesolver: | |
| image: | |
| name: cert-manager-acmesolver-fips | |
| webhook: | |
| image: | |
| name: cert-manager-webhook-fips | |
| cainjector: | |
| image: | |
| name: cert-manager-cainjector-fips | |
| startupapicheck: | |
| image: | |
| name: cert-manager-startupapicheck-fips |
I think this is worth calling out explicitly - the "name" field doesn't seem to be documented in this design
There was a problem hiding this comment.
-fips suggestion included in most recent commit, also briefly documented the "name" field.
| # The container registry | ||
| # +docs:property | ||
| imageRegistry: quay.io | ||
|
|
||
| # The repository namespace | ||
| # Examples: | ||
| # - jetstack | ||
| # - cert-manager | ||
| imageNamespace: jetstack |
There was a problem hiding this comment.
nitpick(non-blocking): Would imageRegistry and imageNamespace live under global (i.e. here?
|
/ok-to-test |
Signed-off-by: felix.phipps <felix.phipps@cyberark.com>
Signed-off-by: felix.phipps <felix.phipps@cyberark.com>
|
/test pull-cert-manager-master-e2e-v1-35 |
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
I don't see a problem with this, it's good work!
I think maybe we'd want to put imageRegistry under global, but I don't think it matters massively for this design doc to capture every last detail like that!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Building on the Design proposed here: #7748
Preview: 20260120.images-in-the-helm-chart.md