[release-1.18] Fail issuance when certificate public key doesn't match CSR (#8380)#8414
Merged
cert-manager-prow[bot] merged 2 commits intocert-manager:release-1.18from Jan 19, 2026
Conversation
…ager#8380) Signed-off-by: calm329 <calmdev0329@gmail.com>
Signed-off-by: calm329 <calmdev0329@gmail.com>
SgtCoDFish
approved these changes
Jan 19, 2026
Member
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/kind feature
I asked in slack if people agreed that this was worthy of backporting, and nobody dissented so I'm going to merge this now.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d8fda9c
into
cert-manager:release-1.18
6 checks passed
Member
|
I incorrectly tagged this as a feature at first, but it's a bug. Manually changing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8403
/assign SgtCoDFish