Skip to content

Minor tweaks#8291

Merged
cert-manager-prow[bot] merged 6 commits intocert-manager:masterfrom
jsoref:minor-tweaks
Dec 4, 2025
Merged

Minor tweaks#8291
cert-manager-prow[bot] merged 6 commits intocert-manager:masterfrom
jsoref:minor-tweaks

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Dec 3, 2025

Pull Request Motivation

There's a plan to promote otherName to beta, so I looked over the PR that introduced it...

Kind

/kind cleanup

Release Note

NONE

jsoref added 3 commits December 2, 2025 16:13
@jsoref
Sort missing field list
96cd769 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: invalid oid syntax
6043501 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: parsecertificaterequest
cdfce67 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@cert-manager-prow cert-manager-prow bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration area/testing Issues relating to testing size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2025
@jsoref jsoref force-pushed the minor-tweaks branch 3 times, most recently from 4d938c0 to e4e330e Compare December 3, 2025 01:42
jsoref added 3 commits December 2, 2025 20:48
@jsoref
spelling: fall back
931f516 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: , or
f2da642 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: , or
8408940 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@wallrj-cyberark wallrj-cyberark mentioned this pull request Dec 3, 2025
Merged
@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Dec 3, 2025

/assign wallrj-cyberark

@jsoref jsoref mentioned this pull request Dec 3, 2025
Merged
wallrj-cyberark
wallrj-cyberark approved these changes Dec 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@wallrj-cyberark wallrj-cyberark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh! Various small fixes to the wording and grammar in our error messages and test titles, which all make sense to me.

@wallrj
Copy link
Copy Markdown
Member

wallrj commented Dec 4, 2025

/approve
/lgtm

@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj, wallrj-cyberark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2025
@wallrj-cyberark
Copy link
Copy Markdown
Member

wallrj-cyberark commented Dec 4, 2025

Test flakes, I suppose:

s: "expected duration of 1h0m0s, got 59m17s (fuzz: 30s) [NotBefore: 2025-12-04T11:12:23Z, NotAfter: 2025-12-04T12:11:40Z]",
-- https://prow.infra.cert-manager.io/view/gs/cert-manager-prow-artifacts/pr-logs/pull/cert-manager_cert-manager/8291/pull-cert-manager-master-e2e-v1-34/1996534895555383296

expected a time delta lower than 2 second. Time expected='2025-12-04 11:32:51.016147188 +0000 UTC', got='2025-12-04 11:32:49 +0000 UTC'
-- https://prow.infra.cert-manager.io/view/gs/cert-manager-prow-artifacts/pr-logs/pull/cert-manager_cert-manager/8291/pull-cert-manager-master-make-test/1996534895446331392

/retest

@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Dec 4, 2025 •
edited
Loading

Job execution failed: Pod got deleted unexpectedly

https://prow.infra.cert-manager.io/view/gs/cert-manager-prow-artifacts/pr-logs/pull/cert-manager_cert-manager/8291/pull-cert-manager-master-e2e-v1-34/1996553561281925120

/retest

@cert-manager-prow cert-manager-prow bot merged commit 49f218c into cert-manager:master Dec 4, 2025
6 checks passed
@jsoref jsoref deleted the minor-tweaks branch December 4, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj-cyberark wallrj-cyberark wallrj-cyberark approved these changes

Assignees

@wallrj-cyberark wallrj-cyberark

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsoref @wallrj @wallrj-cyberark