[release-1.19] Change .global.nodeselector in helm to merge#8233
Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:release-1.19from Nov 5, 2025
Conversation
Changes the .global.nodeselector in the helm chart to a merge. The previous coalesce would overwrite global values with unrelated local values. Signed-off-by: Raimund Hook <rhook@gitlab.com>
Member
|
/kind bug |
wallrj-cyberark
approved these changes
Nov 5, 2025
Member
wallrj-cyberark
left a comment
There was a problem hiding this comment.
This fixes a bug in one of the new 1.19.0 features, after it was released. See:
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj, wallrj-cyberark The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
570ffe2
into
cert-manager:release-1.19
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8195
/assign wallrj-cyberark