[release-1.19] Add defaulting to Certificate - CertificateRequest comparison#8175
Merged
cert-manager-prow[bot] merged 3 commits intocert-manager:release-1.19from Oct 15, 2025
Conversation
…ting mismatches when upgrading Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
- Add TestRequestMatchesSpecIssuerRef covering name, kind, and group - Include cases for defaulted Kind/Group vs empty fields in CRs - Treat empty Kind/Group in CertificateRequest as 'Issuer' and - 'cert-manager.io' to avoid re-issuing certificates after 1.19 Signed-off-by: Richard Wall <richard.wall@cyberark.com>
…esSpec - Explain that IssuerRef comparisons ignore default group and kind - Describe upgrades where CRD defaults can cause transient mismatches - Document issuerKindsEqual and issuerGroupsEqual behavior - Update test comment to describe the equivalence rationale Signed-off-by: Richard Wall <richard.wall@cyberark.com>
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj, wallrj-cyberark The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
de44c90
into
cert-manager:release-1.19
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8160
/assign wallrj-cyberark
CyberArk tracker: VC-46121