Skip to content

Revert breaking change: only default 'kind' when 'group' is cert-manager.io#8157

Closed
inteon wants to merge 2 commits intocert-manager:masterfrom
inteon:revert_kind_api_default
Closed

Revert breaking change: only default 'kind' when 'group' is cert-manager.io#8157
inteon wants to merge 2 commits intocert-manager:masterfrom
inteon:revert_kind_api_default

Conversation

@inteon
Copy link
Copy Markdown
Member

@inteon inteon commented Oct 9, 2025

Fixes #7414 (comment)

Kind

/kind bug

Release Note

BUGFIX: reverting breaking change: we now only default 'kind' when 'group' is `cert-manager.io`

@cert-manager-prow cert-manager-prow bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Oct 9, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thatsmrtalbot for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the area/api Indicates a PR directly modifies the 'pkg/apis' directory label Oct 9, 2025
@inteon
Copy link
Copy Markdown
Member Author

inteon commented Oct 9, 2025

/cc @erikgb

@cert-manager-prow cert-manager-prow bot requested a review from erikgb October 9, 2025 11:03
@cert-manager-prow cert-manager-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 9, 2025
@erikgb erikgb mentioned this pull request Oct 9, 2025
Closed
@erikgb
Copy link
Copy Markdown
Member

erikgb commented Oct 9, 2025

@inteon, I think you also need to remove the defaulting markers.

@inteon
revert breaking change: only default 'kind' when 'group' is cert-mana…
0070f0b 
…ger.io

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon force-pushed the revert_kind_api_default branch from dfc2bee to 66100ec Compare October 9, 2025 11:56
@cert-manager-prow cert-manager-prow bot added the area/deploy Indicates a PR modifies deployment configuration label Oct 9, 2025
@inteon inteon force-pushed the revert_kind_api_default branch from 66100ec to 0070f0b Compare October 9, 2025 12:05
@inteon
Copy link
Copy Markdown
Member Author

inteon commented Oct 9, 2025

/retest

2 similar comments
@wallrj-cyberark
Copy link
Copy Markdown
Member

wallrj-cyberark commented Oct 9, 2025

/retest

@inteon
Copy link
Copy Markdown
Member Author

inteon commented Oct 9, 2025

/retest

@inteon
always apply runtime defaults
12bc862 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Oct 10, 2025

@inteon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-master-make-test 12bc862 link true /test pull-cert-manager-master-make-test
pull-cert-manager-master-e2e-v1-34-upgrade 12bc862 link true /test pull-cert-manager-master-e2e-v1-34-upgrade
pull-cert-manager-master-e2e-v1-34 12bc862 link true /test pull-cert-manager-master-e2e-v1-34

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@erikgb erikgb mentioned this pull request Oct 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikgb erikgb Awaiting requested review from erikgb

Assignees

No one assigned

Labels

area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@inteon @erikgb @wallrj-cyberark