[release-1.18] Increase maximum PEM sizes for leaf certificates and chains#7966
Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:release-1.18from Aug 15, 2025
Conversation
We've seen in cert-manager#7506 that the PEM size maxima we have can be too restrictive for some users who have large numbers of DNS identities in their leaf certificates, preventing them from using cert-manager for those certificates (or stopping them from upgrading). This change adds a large estimate for extra data which might be present in a leaf certificate, based on an experimentally observed increase in the size of a certificate request object by adding new DNS names. We assume 250 large DNS names, totalling about 30kB of size. We shouldn't expect to see a performance change in our existing benchmark with these changes, because the maxBundleSize is used for those tests and that size remains larger than the new maxCertificateChainSize. That seems to be the case from testing: ```console $ go test -bench=. ./internal/pem/... goos: darwin goarch: arm64 pkg: github.com/cert-manager/cert-manager/internal/pem cpu: Apple M3 Max BenchmarkPathologicalInput-16 52 22606764 ns/op PASS ok github.com/cert-manager/cert-manager/internal/pem 2.485s $ go test -bench=. ./internal/pem/... goos: darwin goarch: arm64 pkg: github.com/cert-manager/cert-manager/internal/pem cpu: Apple M3 Max BenchmarkPathologicalInput-16 52 22455893 ns/op PASS ok github.com/cert-manager/cert-manager/internal/pem 2.408s ``` Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
SgtCoDFish
approved these changes
Aug 15, 2025
Member
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/kind bug
Simple cherry-pick
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dfa2d9e
into
cert-manager:release-1.18
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #7961
/assign SgtCoDFish