Skip to content

Migrate away from deprecated fake NewSimpleClientset func#7869

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
erikgb:no-new-simple-clientset
Aug 2, 2025
Merged

Migrate away from deprecated fake NewSimpleClientset func#7869
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
erikgb:no-new-simple-clientset

Conversation

@erikgb
Copy link
Copy Markdown
Member

@erikgb erikgb commented Jul 22, 2025 •
edited
Loading

Pull Request Motivation

This is a follow-up after #7866. Using deprecated APIs is something we should avoid when we can.

It seems like the generated fake.NewClientSet func in Gateway API isn't usable, so I have left it for now, as this must be fixed upstream.

Kind

/kind cleanup

Release Note

NONE

@cert-manager-prow cert-manager-prow bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/monitoring Indicates a PR or issue relates to monitoring area/vault Indicates a PR directly modifies the Vault Issuer code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2025
@erikgb erikgb changed the title Migrate away from deprecated fake NewSimpleClientset func WIP: Migrate away from deprecated fake NewSimpleClientset func Jul 22, 2025
@cert-manager-prow cert-manager-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2025
This was referenced Jul 22, 2025
Open
Merged
@erikgb erikgb force-pushed the no-new-simple-clientset branch 2 times, most recently from 59b6527 to 5c11284 Compare July 28, 2025 21:39
@cert-manager-prow cert-manager-prow bot added area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2025
@erikgb erikgb force-pushed the no-new-simple-clientset branch 2 times, most recently from a2aa52e to 6d49962 Compare July 28, 2025 22:32
@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Jul 29, 2025

/retest

@erikgb erikgb changed the title WIP: Migrate away from deprecated fake NewSimpleClientset func Migrate away from deprecated fake NewSimpleClientset func Jul 29, 2025
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2025
@erikgb erikgb requested a review from wallrj July 30, 2025 09:49
inteon
inteon reviewed Jul 31, 2025
View reviewed changes
inteon
inteon reviewed Jul 31, 2025
View reviewed changes
inteon
inteon reviewed Jul 31, 2025
View reviewed changes
pkg/controller/certificates/requestmanager/requestmanager_controller_test.go
expectedEvents: []string{`Normal Requested Created new CertificateRequest resource "test-1"`},
expectedActions: []testpkg.Action{
testpkg.NewAction(coretesting.NewDeleteAction(cmapi.SchemeGroupVersion.WithResource("certificaterequests"), "testns", "test")),
testpkg.NewAction(coretesting.NewDeleteAction(cmapi.SchemeGroupVersion.WithResource("certificaterequests"), "testns", "test-1")),
Copy link
Copy Markdown
Member

@inteon inteon Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, this error was not detected before?

@inteon
Copy link
Copy Markdown
Member

inteon commented Jul 31, 2025

/approve

@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2025
@erikgb @inteon
Migrate away from deprecated fake NewSimpleClientset func
1eeb639 
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
Co-authored-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@erikgb erikgb force-pushed the no-new-simple-clientset branch from 6d9b970 to 1eeb639 Compare July 31, 2025 13:38
@erikgb erikgb requested a review from inteon July 31, 2025 13:40
@inteon
Copy link
Copy Markdown
Member

inteon commented Aug 2, 2025

/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2025
@cert-manager-prow cert-manager-prow bot merged commit 8e319f7 into cert-manager:master Aug 2, 2025
6 checks passed
@erikgb erikgb mentioned this pull request Aug 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj Awaiting requested review from wallrj

@inteon inteon Awaiting requested review from inteon

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code area/monitoring Indicates a PR or issue relates to monitoring area/vault Indicates a PR directly modifies the Vault Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erikgb @inteon