Skip to content

fix(acme): Use ImplementationSpecific pathType until next breaking-change release#7793

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
sspreitzer:fix/acme-ingress-pathtype-2
Jun 10, 2025
Merged

fix(acme): Use ImplementationSpecific pathType until next breaking-change release#7793
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
sspreitzer:fix/acme-ingress-pathtype-2

Conversation

@sspreitzer
Copy link
Copy Markdown
Contributor

@sspreitzer sspreitzer commented Jun 10, 2025 •
edited by wallrj
Loading

This change introduced a breaking change for users of the ingress-nginx ingress controller. cert-manager will in an upcoming release introduce this breaking change alongside with an option to make the pathType configurable.

This reverts commit 0af46c4.

NONE

@sspreitzer
fix(acme): Use ImplementationSpecific pathType until next major release
2215971 
This change introduced a breaking change for users of the `ingress-nginx` ingress controller. `cert-manager` will in an upcoming release introduce this breaking change alongside with an option to make the pathType configurable.

This reverts commit 0af46c4.

Signed-off-by: Sascha Spreitzer <sascha@spreitzer.ch>
@cert-manager-prow cert-manager-prow bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 10, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Jun 10, 2025

Hi @sspreitzer. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2025
@erikgb
Copy link
Copy Markdown
Member

erikgb commented Jun 10, 2025

/ok-to-test
/cc @wallrj

@cert-manager-prow cert-manager-prow bot requested a review from wallrj June 10, 2025 18:34
@cert-manager-prow cert-manager-prow bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2025
@wallrj wallrj linked an issue Jun 10, 2025 that may be closed by this pull request
[release-1.18] ACME + HTTP01 + Ingress-Nginx: "Error: Path cannot be used with pathType Exact" when strict-validate-path-type is enabled #7791
Closed
@wallrj
Copy link
Copy Markdown
Member

wallrj commented Jun 10, 2025

/kind bug

@cert-manager-prow cert-manager-prow bot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 10, 2025
@wallrj
Copy link
Copy Markdown
Member

wallrj commented Jun 10, 2025

/test pull-cert-manager-master-e2e-v1-33

wallrj
wallrj approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cherry picked your change into #7792

You can see that after upgrading to the latest ingress-nginx, I was able to recreate the error reported in #7791 and after applying your change, the tests passed.

/approve
/lgtm
/cherry-pick release-1.18

@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2025
@wallrj wallrj mentioned this pull request Jun 10, 2025
Merged
@wallrj
Copy link
Copy Markdown
Member

wallrj commented Jun 10, 2025

/kind bug

@cert-manager-prow cert-manager-prow bot merged commit ef97eaf into cert-manager:master Jun 10, 2025
8 checks passed
@wallrj
Copy link
Copy Markdown
Member

wallrj commented Jun 10, 2025

/cherry-pick release-1.18

1 similar comment
@wallrj
Copy link
Copy Markdown
Member

wallrj commented Jun 11, 2025

/cherry-pick release-1.18

@cert-manager-bot
Copy link
Copy Markdown
Contributor

cert-manager-bot commented Jun 11, 2025

@wallrj: new pull request created: #7794

Details

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-bot cert-manager-bot mentioned this pull request Jun 11, 2025
Merged
@cert-manager-prow cert-manager-prow bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 18, 2025
@cert-manager-prow cert-manager-prow bot removed the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 18, 2025
@wallrj
Copy link
Copy Markdown
Member

wallrj commented Jun 18, 2025

This change we re-introduced in #7795, but behind a feature gate, so that ingress-nginx users can disable it if they wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj wallrj approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[release-1.18] ACME + HTTP01 + Ingress-Nginx: "Error: Path cannot be used with pathType Exact" when strict-validate-path-type is enabled

4 participants

@sspreitzer @erikgb @wallrj @cert-manager-bot