Skip to content

Switch to makefile modules completely (part 1)#7718

Open
inteon wants to merge 1 commit intocert-manager:masterfrom
inteon:switch_makefiles_fully
Open

Switch to makefile modules completely (part 1)#7718
inteon wants to merge 1 commit intocert-manager:masterfrom
inteon:switch_makefiles_fully

Conversation

@inteon
Copy link
Copy Markdown
Member

@inteon inteon commented Apr 28, 2025 •
edited by maelvls
Loading

Important changes:

  • different base image
  • different location binary within OCI image
  • removed some make targets that weren't used in CI

Kind

/kind cleanup

Release Note

NONE

CyberArk tracker: VC-46604

@cert-manager-prow cert-manager-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/api Indicates a PR directly modifies the 'pkg/apis' directory labels Apr 28, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thatsmrtalbot for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added area/deploy Indicates a PR modifies deployment configuration size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/testing Issues relating to testing labels Apr 28, 2025
@inteon inteon force-pushed the switch_makefiles_fully branch from 1d4c37a to d5ffd7e Compare April 28, 2025 14:50
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Apr 28, 2025
@inteon inteon force-pushed the switch_makefiles_fully branch 3 times, most recently from 63094d2 to 6df6cd3 Compare April 29, 2025 10:26
@inteon inteon force-pushed the switch_makefiles_fully branch 4 times, most recently from ec59284 to d549bcf Compare April 30, 2025 12:37
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2025
@inteon inteon force-pushed the switch_makefiles_fully branch from d549bcf to 91d5544 Compare April 30, 2025 12:43
@cert-manager-prow cert-manager-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2025
@inteon inteon force-pushed the switch_makefiles_fully branch from 91d5544 to 8776254 Compare April 30, 2025 14:38
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2025
@inteon inteon force-pushed the switch_makefiles_fully branch from 8776254 to 3fbbbbf Compare May 5, 2025 18:43
@cert-manager-prow cert-manager-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2025
@inteon inteon force-pushed the switch_makefiles_fully branch from 3fbbbbf to 1825ab6 Compare May 5, 2025 18:54
@cert-manager-prow cert-manager-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2025
@inteon
Copy link
Copy Markdown
Member Author

inteon commented Jun 14, 2025

/retest

inteon
inteon commented Jun 16, 2025
View reviewed changes
@inteon
Copy link
Copy Markdown
Member Author

inteon commented Jun 16, 2025

TODO: figure out what changes in the build process are required: https://cert-manager.io/docs/contributing/building/

@inteon inteon force-pushed the switch_makefiles_fully branch from 09e0dd1 to 134f390 Compare June 16, 2025 10:07
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2025
@inteon inteon mentioned this pull request Jun 23, 2025
Open
12 tasks
@inteon inteon force-pushed the switch_makefiles_fully branch from 134f390 to 2240637 Compare July 4, 2025 13:24
@cert-manager-prow cert-manager-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2025
@inteon inteon mentioned this pull request Jul 4, 2025
Merged
@inteon inteon force-pushed the switch_makefiles_fully branch from 2240637 to ff4616a Compare July 4, 2025 14:13
@inteon inteon mentioned this pull request Jul 4, 2025
Merged
@inteon inteon force-pushed the switch_makefiles_fully branch from ff4616a to 717e900 Compare July 4, 2025 15:45
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2025
@inteon
migrate OCI builds, Helm and tests to makefile modules
5e425fc 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon force-pushed the switch_makefiles_fully branch from 717e900 to 5e425fc Compare July 19, 2025 20:03
@cert-manager-prow cert-manager-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Jul 23, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2025
@cert-manager-prow cert-manager-prow bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Aug 4, 2025
@maelvls maelvls force-pushed the switch_makefiles_fully branch from de7490f to 5e425fc Compare August 4, 2025 15:22
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Aug 4, 2025
@maelvls maelvls added the cybr Used by CyberArk-employed maintainers to report to line management what's being worked on. label Nov 4, 2025
This was referenced Nov 6, 2025
Open
Open
@maelvls
Copy link
Copy Markdown
Member

maelvls commented Nov 7, 2025

Hey, would we have issues we the number of GitHub Action minutes if we start using them more and more?

Just in case, I've asked the CNCF, and they already have a bunch of beefy GitHub Action runners we can use: cert-manager/community#63.

@erikgb
Copy link
Copy Markdown
Member

erikgb commented Nov 16, 2025

@inteon, are you able to revive this important work? If possible, I would love to see smaller PRs. 😆

@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Dec 30, 2025

@inteon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-master-e2e-v1-33-upgrade 5e425fc link true /test pull-cert-manager-master-e2e-v1-33-upgrade
pull-cert-manager-master-make-verify 5e425fc link true /test pull-cert-manager-master-make-verify
pull-cert-manager-master-e2e-v1-33 5e425fc link true /test pull-cert-manager-master-e2e-v1-33
pull-cert-manager-master-make-test 5e425fc link true /test pull-cert-manager-master-make-test
pull-cert-manager-master-e2e-v1-34-upgrade 5e425fc link true /test pull-cert-manager-master-e2e-v1-34-upgrade
pull-cert-manager-master-e2e-v1-35-upgrade 5e425fc link true /test pull-cert-manager-master-e2e-v1-35-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/acme Indicates a PR directly modifies the ACME Issuer code area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration area/testing Issues relating to testing cybr Used by CyberArk-employed maintainers to report to line management what's being worked on. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@inteon @maelvls @erikgb