Skip to content

WIP: certificate based on HTTPRoute design document#7608

Closed
shellwhale wants to merge 1 commit intocert-manager:masterfrom
shellwhale:shellwhale/http-route-certificate-design-proposal
Closed

WIP: certificate based on HTTPRoute design document#7608
shellwhale wants to merge 1 commit intocert-manager:masterfrom
shellwhale:shellwhale/http-route-certificate-design-proposal

Conversation

@shellwhale
Copy link
Copy Markdown

@shellwhale shellwhale commented Mar 6, 2025

Pull Request Motivation

This is a design document following the following issue #7473

Kind

/kind design

Release Note

NONE

@cert-manager-prow cert-manager-prow bot added kind/design Categorizes issue or PR as related to design. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 6, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maelvls for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Mar 6, 2025

Hi @shellwhale. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 6, 2025
@shellwhale shellwhale changed the title WIP: Create certificate based on HTTPRoute configuration proposal WIP: certificate based on HTTPRoute design document Mar 6, 2025
@shellwhale shellwhale force-pushed the shellwhale/http-route-certificate-design-proposal branch from ee00829 to af3b486 Compare March 6, 2025 06:41
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 6, 2025
@shellwhale shellwhale force-pushed the shellwhale/http-route-certificate-design-proposal branch from af3b486 to 214f405 Compare March 6, 2025 06:42
@shellwhale
docs: add http-route-certificate.md following cert-manager#7473
33e31a0 
Signed-off-by: shellwhale <shellwhale@protonmail.ch>
@shellwhale shellwhale force-pushed the shellwhale/http-route-certificate-design-proposal branch from 214f405 to 33e31a0 Compare March 6, 2025 06:43
@shellwhale shellwhale marked this pull request as draft March 6, 2025 06:49
@cert-manager-bot
Copy link
Copy Markdown
Contributor

cert-manager-bot commented Jun 4, 2025

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

@cert-manager-prow cert-manager-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2025
@cert-manager-bot
Copy link
Copy Markdown
Contributor

cert-manager-bot commented Jul 4, 2025

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
/remove-lifecycle stale

@cert-manager-prow cert-manager-prow bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 4, 2025
@maelvls maelvls mentioned this pull request Jul 7, 2025
Merged
@cert-manager-bot
Copy link
Copy Markdown
Contributor

cert-manager-bot commented Oct 3, 2025

Rotten issues close after 3 months of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close

@cert-manager-prow cert-manager-prow bot closed this Oct 3, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Oct 3, 2025

@cert-manager-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 3 months of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shellwhale shellwhale deleted the shellwhale/http-route-certificate-design-proposal branch January 13, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/design Categorizes issue or PR as related to design. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shellwhale @cert-manager-bot