Skip to content

[Release v1.14.1] Update cmd/cmctl's go.mod to v1.14.1#6711

Merged
jetstack-bot merged 1 commit intocert-manager:release-1.14from
wallrj:update-cmd/ctl/v1.14.1
Feb 2, 2024
Merged

[Release v1.14.1] Update cmd/cmctl's go.mod to v1.14.1#6711
jetstack-bot merged 1 commit intocert-manager:release-1.14from
wallrj:update-cmd/ctl/v1.14.1

Conversation

@wallrj
Copy link
Copy Markdown
Member

@wallrj wallrj commented Feb 2, 2024

This PR cmd/cmctl's go.mod to v1.14.1 as part of the release process.

To the reviewer: the version changes in go.mod must be reviewed.

NONE

@wallrj
Update cmd/ctl's go.mod to v1.14.1
6e52ae1 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/testing Issues relating to testing labels Feb 2, 2024
@wallrj wallrj added this to the 1.14 milestone Feb 2, 2024
@wallrj wallrj mentioned this pull request Feb 2, 2024
Closed
24 tasks
@wallrj wallrj requested a review from inteon February 2, 2024 15:15
inteon
inteon approved these changes Feb 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@wallrj
Copy link
Copy Markdown
Member Author

wallrj commented Feb 2, 2024

/retest

Hopefully only a temporary GitHub error

Got status code 403 for 'https://github.com/cert-manager/cert-manager/releases/download/v1.6.2/cert-manager.yaml' - possibly broken or in-progress release / GitHub down / rate limit

https://prow.build-infra.jetstack.net/view/gs/jetstack-logs/pr-logs/pull/cert-manager_cert-manager/6711/pull-cert-manager-release-1.14-make-test/1753436636391149568

@wallrj
Copy link
Copy Markdown
Member Author

wallrj commented Feb 2, 2024

/kind cleanup

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 2, 2024
@wallrj wallrj requested a review from inteon February 2, 2024 15:29
@wallrj
Copy link
Copy Markdown
Member Author

wallrj commented Feb 2, 2024

@inteon I need /lgtm not LGTM :-)

@inteon
Copy link
Copy Markdown
Member

inteon commented Feb 2, 2024

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
@jetstack-bot jetstack-bot merged commit 701ce53 into cert-manager:release-1.14 Feb 2, 2024
@wallrj wallrj deleted the update-cmd/ctl/v1.14.1 branch February 2, 2024 15:39
@cert-manager-prow cert-manager-prow bot mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inteon inteon Awaiting requested review from inteon

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

1.14

Development

Successfully merging this pull request may close these issues.

3 participants

@wallrj @jetstack-bot @inteon